Path package in context aware #8621
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
How to reproduce :
- Application has a base url (/some-base-url)
- Using "PathPackage"
- Using RequestStackContext (3rd parameter),
- getUrl of asset with absolute path.
Result :
Both "base url" of application and "base path" of PathPackage are ignored.
Example :
Application base url : /some-prefix
$package = new PathPackage('/static/', new StaticVersionStrategy('v1.2'), new RequestStackContext($requestStack));
echo $package->getUrl("/img.png"); // /img.png?v1.2
Check merged PR symfony#8574.
NB : Maybe there a conception problem in Asset component. I my opinion only "base path" should be ignored but "base url" should always be used to prefix the generated asset path.
javiereguiluz
approved these changes
Jan 12, 2018
|
@takman1 thanks for fixing this issue with the leading slash in asset paths in different articles across the Symfony Docs. |
javiereguiluz
added a commit
that referenced
this pull request
Jan 12, 2018
This PR was merged into the 3.3 branch.
Discussion
----------
Path package in context aware
How to reproduce :
- Application has a base url (/some-base-url)
- Using "PathPackage"
- Using RequestStackContext (3rd parameter),
- getUrl of asset with absolute path.
Result :
Both "base url" of application and "base path" of PathPackage are ignored.
Example :
Application base url : /some-prefix
$package = new PathPackage('/static/', new StaticVersionStrategy('v1.2'), new RequestStackContext($requestStack));
echo $package->getUrl("/img.png"); // /img.png?v1.2
Check merged PR #8574.
NB : Maybe there a conception problem in Asset component. I my opinion only "base path" should be ignored but "base url" should always be used to prefix the generated asset path.
Commits
-------
0dbb635 Path package in context aware
|
Thanks for merging @javiereguiluz. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to reproduce :
Result :
Both "base url" of application and "base path" of PathPackage are ignored.
Example :
Application base url : /some-prefix
$package = new PathPackage('/static/', new StaticVersionStrategy('v1.2'), new RequestStackContext($requestStack));
echo $package->getUrl("/img.png"); // /img.png?v1.2
Check merged PR #8574.
NB : Maybe there a conception problem in Asset component. I my opinion only "base path" should be ignored but "base url" should always be used to prefix the generated asset path.